Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forge variant #132

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Forge variant #132

merged 3 commits into from
Oct 2, 2024

Conversation

liamhuber
Copy link
Member

Changing default value for options that passes cached-miniforge to conda-incubator/setup-miniconda to deal with the sunsetting of Mambaforge: https://conda-forge.org/news/2024/07/29/sunsetting-mambaforge/

@liamhuber
Copy link
Member Author

Ok, this is working A-OK where I am testing it:

It's good for review, but I pressingly need to go do childcare stuff. @samwaseda, feel free to merge it and release a new patch version (I think patching is fair since even though we change a default, the sunsetting alert explicitly says these two things are now equivalent)

@samwaseda samwaseda merged commit 72e1239 into main Oct 2, 2024
@samwaseda samwaseda deleted the forge-variant branch October 2, 2024 06:28
@samwaseda
Copy link
Member

@mbruns91 help

@samwaseda
Copy link
Member

@mbruns91 help

@mbruns91
Copy link
Contributor

Sorry, lost track of this one. Done.

@samwaseda
Copy link
Member

So the new version has been released (thanks @mbruns91 !!!) but it looks like now "forge-variant" is making a problem... (cf. this issue)

@mbruns91
Copy link
Contributor

mbruns91 commented Oct 15, 2024

In the workflow-file over there, it says

jobs:
  pyiron:
    uses: pyiron/actions/.github/workflows/pyproject-release.yml@actions-3.3.2
...

so I'm not quite sure what's happening. Looks like something is cached?
Maybe you just have to wait and re-run?

@mbruns91
Copy link
Contributor

Oh, no, I found the issue. In the new release, ...@forge-variant is still referenced at some places. I guess something went wrong during the release. I'm working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants