Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of elaston units #61

Merged
merged 10 commits into from
Jan 3, 2025
Merged

Get rid of elaston units #61

merged 10 commits into from
Jan 3, 2025

Conversation

samwaseda
Copy link
Member

I got rid of the elaston units, but it turned out that the tests were not quite testing the unit functionalities inside elaston, so I'm adding more tests now.

Copy link

github-actions bot commented Jan 3, 2025

Binder 👈 Launch a binder notebook on branch pyiron/elaston/get_rid_of_elaston_units

Copy link

codacy-production bot commented Jan 3, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.34% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (34582cf) 671 655 97.62%
Head commit (32def03) 586 (-85) 574 (-81) 97.95% (+0.34%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#61) 32 32 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@coveralls
Copy link

coveralls commented Jan 3, 2025

Pull Request Test Coverage Report for Build 12596956825

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 97.952%

Files with Coverage Reduction New Missed Lines %
linear_elasticity.py 1 98.61%
elastic_constants.py 1 99.16%
Totals Coverage Status
Change from base Build 12595238802: 0.3%
Covered Lines: 574
Relevant Lines: 586

💛 - Coveralls

@samwaseda
Copy link
Member Author

In principle more tests should be added, but there would be too many changes at once, so I merge this one for now.

@samwaseda samwaseda merged commit ba07113 into main Jan 3, 2025
17 checks passed
@samwaseda samwaseda deleted the get_rid_of_elaston_units branch January 3, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants