Port access by attribute #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can safely have port labels the same as the built-in list method names without getting in trouble
|
|
Because of a codacy nit
…ort_access_by_attribute # Conflicts: # ironflow/model/node.py
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overrides the
inputsandoutputsattributes of a node with a new list-like class. This class allows elements that areNodePortinstances (or their values) to be accessed as attributes according to their label strings.This closes #108.
We do introduce a little danger here: accessing port values this way (instead of through
Node.input(index), or at leastNode.inputs[index].get_val()) bypasses functionality for the exec mode, and for running with an executor in data mode (although for the latter I don't see in the ryvencore source code any difference to just directly grabbingval...) If/when I get test cases up for exec mode, this can be revisited.