More colour control #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start removing formatting and presentation from the logic. I'm not totally happy with the factory pattern -- ports don't have a shared parent, and only nodes really need title font stuff. I'll probably adjust it later, but it's good enough for now.
|
How the new colours are looking, with data in green and exec in blue:
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.
Distinguishing data and exec ports by colour, as suggested in #8.
Under the hood I'm also trying to better encapsulate logic from presentation. Right now that means pulling out the
Layoutclasses into their own module, but these in turn should also probably be fed by some sort of theme.yml file. I'm also not totally happy with the factory pattern for the layouts, as I have some ugly class stuff like the two port classes redefining shared values (instead of having a shared parent) and all the classes carrying around title data that should really only be for the node class.