Match the list signature from colab #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My local python installation allows a `seq` kwarg to list, which caused an error on my binder. I'm still not 100% if this is some pycharm magic (unlikely) or a change between 3.8 and 3.11 (likely). Interestingly, even the mybinder help for `list??` erroneously states `Init signature: list(iterable=(), /)`. In fact, no kwargs are possible. Only a single (iterable) arg is allowable, but I'm just going to follow the colab `list??` and allow the full generic signature and let users hit the error themselves.
|
|
|
Pip-check failure is due to upstream inconsistencies between pyiron_base and mendeleev (a pyiron_atomistics dep). I won't worry about it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My local python installation allows a
seqkwarg to list, which caused an error on my binder. I'm still not 100% if this is some pycharm magic (unlikely) or a change between 3.8 and 3.11 (likely). Interestingly, even the mybinder help forlist??erroneously statesInit signature: list(iterable=(), /). In fact, no kwargs are possible. Only a single (iterable) arg is allowable, but I'm just going to follow the colablist??and allow the full generic signature and let users hit the error themselves.