Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the edge case where you slice 0 #192

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Handle the edge case where you slice 0 #192

merged 3 commits into from
Apr 24, 2023

Conversation

liamhuber
Copy link
Member

[-0:] is the same as [0:], and radically different for how, e.g. [-1:] vs [1:] works. Derp.

Solves the issue of the entire display getting closed down when you (sometimes) turn off the node representation widget.

Closes the last part of #189

[-0:] is the same as [0:], and radically different for how, e.g. [-1:] vs [1:] works. Derp.
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/ironflow/display_crashes

@liamhuber
Copy link
Member Author

Run pip check
pyiron-base 0.5.36 has requirement sqlalchemy>=2.0.9, but you have sqlalchemy 1.4.46.
Error: Process completed with exit code 1.

I forgot to un-pin sqlalchemy in the pyiron_ontology conda env file, so I need to go bump that and bump my dependency here too.

@liamhuber liamhuber added the format_black Invoke black formatting CI label Apr 24, 2023
@liamhuber liamhuber merged commit c7c7d20 into main Apr 24, 2023
@liamhuber liamhuber deleted the display_crashes branch April 24, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black Invoke black formatting CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants