Begin to partition logic #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a hideous commit, the scope of which belies my continued lack of familiarity with ipywidgets and guis. The one redeeming factor is that the Tab class actually has a bug that wasn't obvious in the old formulation, and finding and working around this is part of why this got so ugly. Whenever the number of scripts change, things are a bit clunky as I totally rewrite the canvases; this might need fixing later, or it might be OK since that's not a common operation and it's still only fractional seconds for small graphs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly focused on disentangling the front- and back-end logic. No big user-side changes here, just lots of QoL stuff on the dev side.