Get chemical symbols

[samwaseda]

I added neigh.chemical_symbols which gives the chemical symbols of the neighboring atoms.

I was not sure if I should call it neigh.get_chemical_symbols() or make it a property. Since there's no argument to add, I decided to make it a property, but I'm open to suggestions.

[coveralls]

Pull Request Test Coverage Report for Build 617775079

• 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.006%) to 64.719%

---

Totals
Change from base Build 615074828:	0.006%
Covered Lines:	10658
Relevant Lines:	16468

---

💛 - Coveralls

[pmrv]

lgtm

[liamhuber]

I was not sure if I should call it neigh.get_chemical_symbols() or make it a property. Since there's no argument to add, I decided to make it a property, but I'm open to suggestions.

I like this choice. My rationale is this:

• Requires arguments --> Method (obviously 😛)
• Alters parent object in place --> Method
• Best described by a verb --> ...Method? Usually at least. But in this case it typically alters the parent object in place.
• Else --> Property. ❤️ properties.

[liamhuber]

Cool, cool cool cool.

Change suggestions in the review, but nothing barring merging IMO, just see what you like.

[liamhuber]

codacy is going to whine that this could be on one line. I don't actually care strongly about this formatting choice, but I do like making codacy shut up 😉

[samwaseda]

Oh ok I didn't know that.

[liamhuber]

❤️ tests