Separate input writer from pyiron #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As it turned out that there are quite a few things to be done, it’s probably going to stay draft for some time |
|
Obviously the input writers are not totally separated, but since there are already so many lines that got changed, I’m gonna stop for this PR. Following the comments from @liamhuber and @niklassiemer I leave |
samwaseda
added
integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My Christmas vacation work
Main changes:
InputWriterdoes not exist anymore - it also made very little sense beforecopy_potentialsandwrite_spin_constraintsare now independent functionscopy_potentialsdoes very little right now - I'm not even sure if it merits to be an independent function