Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods to convert MP results to StructureStorage/list #846

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Add methods to convert MP results to StructureStorage/list #846

merged 1 commit into from
Oct 28, 2022

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Oct 27, 2022

Adds two QoL methods on the object returned from pr.create.structure.materialsproject to convert the structures to other objects.

@pmrv pmrv added the enhancement New feature or request label Oct 27, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3335957034

  • 3 of 8 (37.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 68.653%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/atomistics/structure/factories/materialsproject.py 3 8 37.5%
Totals Coverage Status
Change from base Build 3323553287: -0.01%
Covered Lines: 12074
Relevant Lines: 17587
💛 - Coveralls

@pmrv pmrv merged commit 6c2030d into master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmrv @coveralls