Fixes outcar parsing for VASP >6.1.0 #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will update the test suite to include different VASP version OUTCARs and test for parsing, but due to the urgency of this request (and general delays despite the urgency) I would like to merge this ASAP and include the more comprehensive tests later. |
Pull Request Test Coverage Report for Build 3438625860
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vasp import due to error in VASP versions > 6.1.0 due to extra Fermi energy line at the end of band information.
Fixes pyiron/pyiron#833 #865
Includes vasp version scraper for future use in this kind of case, in case a more complicated fix is necessary in the future.