-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename master to main #894
Conversation
Also for a couple references to github.com/pyiron/pyiron/tree/master, which worked because github kindly redirects us, but should still be main now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
It seems the migration on |
@jan-janssen I think we should also update some external links, e.g. appveyor
Right now I'm still fighting with "access denied" errors there so I can't yet confirm that this got updated to main. Over on coveralls I took a look at pyiron_base, and there we need to manually tell them to start looking at "main", and will need to update our links accordingly |
I guess we no longer use |
Ok, I try to do this after work. |
Ok, then we can leave it updated and remove these from the documentation entirely in a separate PR. |
Don't worry about it, I'm pretty sure I misspoke -- it looks like coveralls is running on each branch (since we do call it on the branches' CI) so once the push CI gets run on main I think it will all auto-update. Links still need to be updated in our docs, but that can be done as part of these PRs |
Turns out I didn't misspeak, it did need to be updated on coveralls. But I just had to go into the repo settings there an "resync", so it was easy. |
Also for a couple references to github.com/pyiron/pyiron/tree/master, which worked because github kindly redirects us, but should still be main now.