Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename master to main #894

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Rename master to main #894

merged 3 commits into from
Dec 5, 2022

Conversation

liamhuber
Copy link
Member

Also for a couple references to github.com/pyiron/pyiron/tree/master, which worked because github kindly redirects us, but should still be main now.

Also for a couple references to github.com/pyiron/pyiron/tree/master, which worked because github kindly redirects us, but should still be main now.
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jan-janssen
Copy link
Member

It seems the migration on pyiron_base is slowing down the unit tests not only in pyiron_base but also here on pyiron_atomistics.

@liamhuber
Copy link
Member Author

@jan-janssen I think we should also update some external links, e.g. appveyor

Right now I'm still fighting with "access denied" errors there so I can't yet confirm that this got updated to main.

Over on coveralls I took a look at pyiron_base, and there we need to manually tell them to start looking at "main", and will need to update our links accordingly

@jan-janssen
Copy link
Member

@jan-janssen I think we should also update some external links, e.g. appveyor

I guess we no longer use appveyor as now all our tests are executed by the Github CI, previously we used appveyor for tests on windows.

@jan-janssen
Copy link
Member

Over on coveralls I took a look at pyiron_base, and there we need to manually tell them to start looking at "main", and will need to update our links accordingly

Ok, I try to do this after work.

@liamhuber
Copy link
Member Author

@jan-janssen I think we should also update some external links, e.g. appveyor

I guess we no longer use appveyor as now all our tests are executed by the Github CI, previously we used appveyor for tests on windows.

Ok, then we can leave it updated and remove these from the documentation entirely in a separate PR.

@liamhuber
Copy link
Member Author

Over on coveralls I took a look at pyiron_base, and there we need to manually tell them to start looking at "main", and will need to update our links accordingly

Ok, I try to do this after work.

Don't worry about it, I'm pretty sure I misspoke -- it looks like coveralls is running on each branch (since we do call it on the branches' CI) so once the push CI gets run on main I think it will all auto-update.

Links still need to be updated in our docs, but that can be done as part of these PRs

@liamhuber liamhuber merged commit 16f49ed into main Dec 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the ci_uses_main branch December 5, 2022 17:50
@liamhuber
Copy link
Member Author

Over on coveralls I took a look at pyiron_base, and there we need to manually tell them to start looking at "main", and will need to update our links accordingly

Ok, I try to do this after work.

Don't worry about it, I'm pretty sure I misspoke -- it looks like coveralls is running on each branch (since we do call it on the branches' CI) so once the push CI gets run on main I think it will all auto-update.

Links still need to be updated in our docs, but that can be done as part of these PRs

Turns out I didn't misspeak, it did need to be updated on coveralls. But I just had to go into the repo settings there an "resync", so it was easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants