Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issues cause by deprecated numpy float #914

Merged
merged 1 commit into from
Dec 22, 2022
Merged

fix issues cause by deprecated numpy float #914

merged 1 commit into from
Dec 22, 2022

Conversation

Leimeroth
Copy link
Member

@Leimeroth Leimeroth commented Dec 22, 2022 •
edited
Loading

After updating today my pyiron quitted its job because np.float is removed in numpy 1.24
This should fix it.

EDIT:
Actual code changes are only a few lines, most come from black formatter

@Leimeroth Leimeroth requested a review from pmrv December 22, 2022 07:24
pmrv
pmrv approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@pmrv pmrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Leimeroth Leimeroth merged commit 6272d70 into main Dec 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-np-float branch December 22, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmrv pmrv pmrv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leimeroth @pmrv