Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Add new exception for calc_minimize. #933

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

KuhnMn
Copy link
Contributor

@KuhnMn KuhnMn commented Jan 17, 2023

Solution for #696. Add a new exception to the calc_minimize method that is raised when pressure is about to be calculated while the rotation_matrix is None. This would raise an exception anyways, but with a more generic message.

Add a new exception to the calc_minimize method that is raised when pressure is about to be calculated while the rotation_matrix is None. This would raise an exception anyways, but with a more generic message.
Reformat exception to fit style guide
@KuhnMn
Copy link
Contributor Author

KuhnMn commented Jan 18, 2023

Hello, I am having some issues understanding the failing workflows.
From the logs, the issue in both cases seems to be that the setuptools_scm module is not found. However, I changed nothing regarding the packages or modules of the project. With this being my first contribution, I'd appreciate some help in fixing the pipeline issues.
Thank you in advance!

@jan-janssen
Copy link
Member

Hi @KuhnMn ,

Unfortunately, we currently have an issue with the mpi_api package pyiron_atomistics depends on:
pyiron/pyiron_base#983

We are working on fixing this as soon as possible.

Best,

Jan

@KuhnMn
Copy link
Contributor Author

KuhnMn commented Jan 18, 2023

Hi, @jan-janssen

thank you for the clarification!

Best,

Maximilian

@jan-janssen jan-janssen reopened this Jan 18, 2023
@jan-janssen
Copy link
Member

It is fixed

@KuhnMn
Copy link
Contributor Author

KuhnMn commented Jan 18, 2023

Thanks a lot, that resolved the last checks not passing!

Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jan-janssen jan-janssen merged commit f2ecedc into pyiron:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants