Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate quickff and yaff to pyiron_gpl #94

Merged
merged 5 commits into from
Mar 17, 2021
Merged

Migrate quickff and yaff to pyiron_gpl #94

merged 5 commits into from
Mar 17, 2021

Conversation

jan-janssen
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Mar 1, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 660777742

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.7%) to 66.576%
Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/atomistics/structure/periodic_table.py 1 82.35%
Totals Coverage Status
Change from base Build 660776656: 1.7%
Covered Lines: 10332
Relevant Lines: 15519
💛 - Coveralls

@jan-janssen jan-janssen linked an issue Mar 1, 2021 that may be closed by this pull request
Moving yaff and quickff to pyiron_gpl #91
Closed
@stale
Copy link

stale bot commented Mar 15, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 15, 2021
@stale stale bot removed the stale label Mar 15, 2021
@jan-janssen
Copy link
Member Author

Once the tests passed this can be merged as the same modules are already included in pyiron_gpl pyiron/pyiron_gpl#7

@jan-janssen jan-janssen merged commit d9d7cf9 into master Mar 17, 2021
@delete-merged-branch delete-merged-branch bot deleted the migrate_quickff_and_yaff branch March 17, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanderBorgmans SanderBorgmans Awaiting requested review from SanderBorgmans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving yaff and quickff to pyiron_gpl
2 participants
@jan-janssen @coveralls