Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Executable Dataclass #1580

Merged
merged 18 commits into from
Aug 15, 2024
Merged

Executable Dataclass #1580

merged 18 commits into from
Aug 15, 2024

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Aug 3, 2024 •
edited
Loading

Following #1578 this pull request replaces the DataContainer in the Executable class with a dataclass.

@jan-janssen jan-janssen marked this pull request as draft August 3, 2024 05:28
@jan-janssen jan-janssen requested a review from pmrv August 3, 2024 05:47
@jan-janssen jan-janssen marked this pull request as ready for review August 3, 2024 05:47
pmrv
pmrv approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@pmrv pmrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some code nits, but generally looks ok.

pyiron_base/dataclasses/job.py Outdated Show resolved Hide resolved
pyiron_base/jobs/job/extension/executable.py Show resolved Hide resolved
pyiron_base/jobs/job/extension/executable.py Outdated Show resolved Hide resolved
pyiron_base/jobs/job/extension/executable.py Outdated Show resolved Hide resolved
tests/unit/flex/test_executablecontainer.py Outdated Show resolved Hide resolved
@jan-janssen @pmrv
Update pyiron_base/jobs/job/extension/executable.py
48cc012 
Co-authored-by: Marvin Poul <poul@mpie.de>
jan-janssen and others added 9 commits August 15, 2024 16:27
@jan-janssen
Update pyiron_base/jobs/job/extension/executable.py
f156b01
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4abe24c 
for more information, see https://pre-commit.ci
@jan-janssen @pmrv
Update pyiron_base/dataclasses/job.py
6c9d161 
Co-authored-by: Marvin Poul <poul@mpie.de>
@jan-janssen @pmrv
Update pyiron_base/jobs/job/extension/executable.py
dc8ec6b 
Co-authored-by: Marvin Poul <poul@mpie.de>
@jan-janssen @pmrv
Update pyiron_base/jobs/job/extension/executable.py
c06ede3 
Co-authored-by: Marvin Poul <poul@mpie.de>
@jan-janssen @pmrv
Update pyiron_base/jobs/job/extension/executable.py
5cce6f2 
Co-authored-by: Marvin Poul <poul@mpie.de>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7b94de9 
for more information, see https://pre-commit.ci
@jan-janssen
Update test_executablecontainer.py
2b2f99b
@jan-janssen @pmrv
Update tests/unit/flex/test_executablecontainer.py
8afdb7d 
Co-authored-by: Marvin Poul <poul@mpie.de>
@jan-janssen jan-janssen merged commit a3443e6 into main Aug 15, 2024
26 checks passed
@jan-janssen jan-janssen deleted the executable_dataclass branch August 15, 2024 14:50
@jan-janssen jan-janssen mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmrv pmrv pmrv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-janssen @pmrv