Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] Not create tmp file when copying everything #1589

Merged
merged 14 commits into from
Aug 14, 2024
Merged

[patch] Not create tmp file when copying everything #1589

merged 14 commits into from
Aug 14, 2024

Conversation

samwaseda
Copy link
Member

@pmrv pointed this case out, and somehow the PR got closed so I open another one.

@samwaseda samwaseda added the minor add functionality in a backward compatible manner label Aug 7, 2024
@samwaseda samwaseda marked this pull request as draft August 7, 2024 07:17
@samwaseda samwaseda mentioned this pull request Aug 7, 2024
Merged
@samwaseda samwaseda changed the base branch from main to not_use_relpath August 7, 2024 07:53
@samwaseda samwaseda marked this pull request as ready for review August 7, 2024 08:03
jan-janssen
jan-janssen approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Base automatically changed from not_use_relpath to main August 8, 2024 19:37
@samwaseda
Copy link
Member Author

apparently the new case is not at all covered by unit tests.

@samwaseda
Copy link
Member Author

I don't understand why it's failing. I convert it to draft for now.

@samwaseda samwaseda marked this pull request as draft August 9, 2024 07:54
@pmrv
Copy link
Contributor

pmrv commented Aug 9, 2024

The error comes from .git/objects/pack/... files which are read-only set by git. So I'm guessing the import tries to pack some git repository (base itself?) by accident and when the export comes around it tries to restore the same packed object files again in place, which causes the error.

@samwaseda samwaseda changed the base branch from main to restructure_archive August 13, 2024 15:45
@samwaseda samwaseda marked this pull request as ready for review August 13, 2024 15:48
@samwaseda
Copy link
Member Author

I don't know why but it looks like the changes made in #1595 seem to have solved the problems.

@samwaseda samwaseda removed the minor add functionality in a backward compatible manner label Aug 13, 2024
@samwaseda samwaseda added the patch backward compatible bug fixes label Aug 13, 2024
@samwaseda samwaseda changed the title Not create tmp file when copying everything [patch] Not create tmp file when copying everything Aug 13, 2024
Base automatically changed from restructure_archive to main August 14, 2024 11:16
@samwaseda samwaseda merged commit afd43cf into main Aug 14, 2024
27 checks passed
@samwaseda samwaseda deleted the not_copy branch August 14, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-janssen jan-janssen jan-janssen approved these changes

Assignees
No one assigned
Labels
patch backward compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samwaseda @pmrv @jan-janssen