Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Append tag when patch, minor or major is added #1599

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Conversation

samwaseda
Copy link
Member

I got this from ChatGPT.

@samwaseda samwaseda added the patch backward compatible bug fixes label Aug 13, 2024
@github-actions github-actions bot changed the title Append tag when patch, minor or major is added [patch] Append tag when patch, minor or major is added Aug 13, 2024
@samwaseda
Copy link
Member Author

ok it seems to work

@samwaseda samwaseda added minor add functionality in a backward compatible manner and removed patch backward compatible bug fixes labels Aug 13, 2024
@github-actions github-actions bot changed the title [patch] Append tag when patch, minor or major is added [atch] Append tag when patch, minor or major is added Aug 13, 2024
@github-actions github-actions bot changed the title [atch] Append tag when patch, minor or major is added [minor] [patch] Append tag when patch, minor or major is added Aug 13, 2024
@samwaseda samwaseda removed the minor add functionality in a backward compatible manner label Aug 13, 2024
@github-actions github-actions bot changed the title [minor] [patch] Append tag when patch, minor or major is added [inor] [patch] Append tag when patch, minor or major is added Aug 13, 2024
@pmrv
Copy link
Contributor

pmrv commented Aug 13, 2024

Seems like it go to pyiron/actions, but if it works I'm good with it.

@samwaseda
Copy link
Member Author

Seems like it go to pyiron/actions, but if it works I'm good with it.

Yeah I agree. I leave the decision to @liamhuber

@samwaseda samwaseda changed the title [inor] [patch] Append tag when patch, minor or major is added Append tag when patch, minor or major is added Aug 13, 2024
@samwaseda samwaseda added the patch backward compatible bug fixes label Aug 13, 2024
@github-actions github-actions bot changed the title Append tag when patch, minor or major is added [patch] Append tag when patch, minor or major is added Aug 13, 2024
@samwaseda samwaseda removed the patch backward compatible bug fixes label Aug 13, 2024
@github-actions github-actions bot changed the title [patch] Append tag when patch, minor or major is added [] Aend g wen , minor or mjor is dded Aug 13, 2024
@samwaseda samwaseda changed the title [] Aend g wen , minor or mjor is dded Append tag when patch, minor or major is added Aug 13, 2024
@samwaseda
Copy link
Member Author

ok clearly it's not working when I try to remove the tag

@samwaseda samwaseda added the patch backward compatible bug fixes label Aug 13, 2024
@github-actions github-actions bot changed the title Append tag when patch, minor or major is added [patch] Append tag when patch, minor or major is added Aug 13, 2024
@samwaseda samwaseda removed the patch backward compatible bug fixes label Aug 13, 2024
@samwaseda samwaseda changed the title [patch] Append tag when patch, minor or major is added Append tag when patch, minor or major is added Aug 13, 2024
@samwaseda samwaseda added the major incompatible API changes label Aug 13, 2024
@github-actions github-actions bot changed the title Append tag when patch, minor or major is added [major] Append tag when patch, minor or major is added Aug 13, 2024
@samwaseda samwaseda removed the major incompatible API changes label Aug 13, 2024
@samwaseda samwaseda changed the title [major] Append tag when patch, minor or major is added Append tag when patch, minor or major is added Aug 13, 2024
@samwaseda samwaseda added enhancement New feature or request patch backward compatible bug fixes labels Aug 13, 2024
@github-actions github-actions bot changed the title Append tag when patch, minor or major is added [patch] Append tag when patch, minor or major is added Aug 13, 2024
@samwaseda
Copy link
Member Author

ok the removal is still not working. I don't find it particularly critical because it's rather rare that you would change the level. If you guys see how to do it feel free to change it.

@samwaseda samwaseda removed the patch backward compatible bug fixes label Aug 13, 2024
@github-actions github-actions bot changed the title [patch] Append tag when patch, minor or major is added Aend g wen , minor or mjor is dded Aug 13, 2024
@samwaseda samwaseda changed the title Aend g wen , minor or mjor is dded Append tag when patch, minor or major is added Aug 13, 2024
@samwaseda samwaseda added the patch backward compatible bug fixes label Aug 13, 2024
@github-actions github-actions bot changed the title Append tag when patch, minor or major is added [patch] Append tag when patch, minor or major is added Aug 13, 2024
@samwaseda samwaseda removed the patch backward compatible bug fixes label Aug 13, 2024
@github-actions github-actions bot changed the title [patch] Append tag when patch, minor or major is added Append tag when patch, minor or major is added Aug 13, 2024
@samwaseda
Copy link
Member Author

Finally it worked. My attempts made this PR one of the most colourful PRs in this repository.

@samwaseda samwaseda added the patch backward compatible bug fixes label Aug 13, 2024
@github-actions github-actions bot changed the title Append tag when patch, minor or major is added [patch] Append tag when patch, minor or major is added Aug 13, 2024
@liamhuber
Copy link
Member

Seems like it go to pyiron/actions, but if it works I'm good with it.

Yeah I agree. I leave the decision to @liamhuber

This was a rollercoaster and then we got here:

Finally it worked. My attempts made this PR one of the most colourful PRs in this repository.

And then yes, I would very much like this to be in pyiron/actions!

@samwaseda
Copy link
Member Author

Now does it mean I should merge it here or I shouldn't?

@liamhuber
Copy link
Member

Now does it mean I should merge it here or I shouldn't?

Jan wants base independent of pyiron/actions, so I think this is a "yes and" rather than an "either-or"

@samwaseda samwaseda merged commit 120614f into main Aug 13, 2024
35 checks passed
@samwaseda samwaseda deleted the label_to_title branch August 13, 2024 20:20
@samwaseda
Copy link
Member Author

Jan wants base independent of pyiron/actions, so I think this is a "yes and" rather than an "either-or"

ok are you going to do it? I don't know how things are organised in pyiron/actions.

@liamhuber
Copy link
Member

Jan wants base independent of pyiron/actions, so I think this is a "yes and" rather than an "either-or"

ok are you going to do it? I don't know how things are organised in pyiron/actions.

It doesn't have to be you, but someone other than me should do this. It's low-hanging fruit and people not-me need to know how that repo runs.

This looks completely stand-alone to me, which means it's a great candidate for putting as an action (as opposed to a reusable workflow). That means you can even ignore the directions for how to add stuff to pyiron/actions because there's no need to re-direct internal tag references. Just:

  • Check out a branch
  • Make a new folder named after the action and put a action.yml file in it
  • Write the action:
    • Add the name field as usual
    • add a description field beneath it
    • This doesn't seem like it needs any input, so everything here between name and steps can be replaced with runs:\n\tusing: 'composite'
    • Copy the steps from here into the file
    • Here is an almost-as-simple example to follow
  • Make a PR in some other repo and test your action out with some new .github/workflow that leverages the on: stuff you didn't copy into the action and leverage the action like:
name: Testing Sam's Action

on:
  pull_request:
    types: [labeled, unlabeled]

jobs:
  whatever-you-call-the-job:
    runs-on: ubuntu-latest
    steps:
    - uses: pyiron/actions/whatever-you-called-the-action@whatever-you-called-your-branch

We could incorporate it into the .github/workflows/pr-labeled.yml reusable workflow later, but you can see in that demo script that just having the meat of the stuff encapsulated in an action already makes it a lot easier to leverage in other places.

This second PR should nicely leverage the new action, at which point you can ping me for review, reference the second PR in the actions PR, then we can merge the actions PR and delete the PR and branch that was being used elsewhere to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request patch backward compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants