-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[patch] Append tag when patch, minor or major is added #1599
Conversation
ok it seems to work |
Seems like it go to pyiron/actions, but if it works I'm good with it. |
Yeah I agree. I leave the decision to @liamhuber |
ok clearly it's not working when I try to remove the tag |
ok the removal is still not working. I don't find it particularly critical because it's rather rare that you would change the level. If you guys see how to do it feel free to change it. |
Finally it worked. My attempts made this PR one of the most colourful PRs in this repository. |
This was a rollercoaster and then we got here:
And then yes, I would very much like this to be in pyiron/actions! |
Now does it mean I should merge it here or I shouldn't? |
Jan wants base independent of pyiron/actions, so I think this is a "yes and" rather than an "either-or" |
ok are you going to do it? I don't know how things are organised in |
It doesn't have to be you, but someone other than me should do this. It's low-hanging fruit and people not-me need to know how that repo runs. This looks completely stand-alone to me, which means it's a great candidate for putting as an action (as opposed to a reusable workflow). That means you can even ignore the directions for how to add stuff to pyiron/actions because there's no need to re-direct internal tag references. Just:
We could incorporate it into the This second PR should nicely leverage the new action, at which point you can ping me for review, reference the second PR in the actions PR, then we can merge the actions PR and delete the PR and branch that was being used elsewhere to test it. |
I got this from ChatGPT.