Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Use tempfile to open compressed data #1601

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

samwaseda
Copy link
Member

No description provided.

@samwaseda samwaseda added the patch backward compatible bug fixes label Aug 14, 2024
@samwaseda samwaseda added patch backward compatible bug fixes and removed patch backward compatible bug fixes labels Aug 14, 2024
@samwaseda
Copy link
Member Author

@liamhuber it looks like as soon as the jobs get cancelled label-to-title also gets cancelled. Do you think there's a good way to make it run anyway?

@github-actions github-actions bot changed the title Use tempfile to open compressed data [patch] Use tempfile to open compressed data Aug 14, 2024
@liamhuber
Copy link
Member

@liamhuber it looks like as soon as the jobs get cancelled label-to-title also gets cancelled. Do you think there's a good way to make it run anyway?

It's not clear what you mean -- if you manually cancel jobs, it should get cancelled. If some other workflows fail, e.g. unit tests, label-to-title should be unaffected because it's in its own separate workflow file. Can you give more detail for the undesirable symptom?

@liamhuber
Copy link
Member

Ahhh, nevermind, I think I can see by looking at the page history: you pushed, added the label, then the bot pushed over top of you and that literally restarted the entire CI pipeline.

...nope, don't know how to fix that. I can't rule out our ability to power through here, but my gut tells me it's unlikely GitHub gives us that power.

@liamhuber
Copy link
Member

There is a work-around where we trigger on: push and do a check whether the title matches expectations given the label, and if not then update it. But that is a slightly different action than the one you wrote.

@samwaseda
Copy link
Member Author

ok at the end of the day it's not so much work to add [patch] in the title myself, so for now I'm gonna keep it like this.

@samwaseda samwaseda merged commit 48a9c1f into main Aug 15, 2024
31 checks passed
@samwaseda samwaseda deleted the use_temp_import branch August 15, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch backward compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants