Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add draw() function to delayed object #1664

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Add draw() function to delayed object #1664

merged 2 commits into from
Oct 12, 2024

Conversation

jan-janssen
Copy link
Member

No description provided.

@jan-janssen jan-janssen marked this pull request as draft October 12, 2024 06:31
@jan-janssen jan-janssen marked this pull request as ready for review October 12, 2024 06:54
samwaseda
samwaseda approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@samwaseda samwaseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, but in order for the user to have full flexibility, we should also think about returning the SVG object at some point.

@jan-janssen
Copy link
Member Author

we should also think about returning the SVG object at some point.

I real like the idea - I add it to the list and address it in a separate pull request.

@jan-janssen jan-janssen merged commit f49dccf into main Oct 12, 2024
26 checks passed
@jan-janssen jan-janssen deleted the delayed_draw branch October 12, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwaseda samwaseda samwaseda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-janssen @samwaseda