-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement decorators in pyiron_base
#1667
Conversation
@jan-janssen I unified |
for more information, see https://pre-commit.ci
Nice catch - I really like the suggestion. From my perspective it is ready to be merged. |
Can you copy and paste your first comment in this PR in the doc string? |
for more information, see https://pre-commit.ci
pyiron_base
pyiron_base
I updated the pull request based on the feedback from the pyiron meeting today. |
@samwaseda I added the doc strings as requested. |
Co-authored-by: Sam Dareska <37879103+samwaseda@users.noreply.github.com>
Co-authored-by: Sam Dareska <37879103+samwaseda@users.noreply.github.com>
For future reference, the decorators in |
First implementation with decorator arguments:
The disadvantage of this approach is that the decorator requires the
()
even without parameters:To address this limitation I created a second implementation: