Update pack and unpack methods #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samwaseda here is the development on pack and unpack |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@srmnitc Can you merge with the new |
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This might be an edge case -but when I called pr.pack('.') it deleted all my calculations and everything in my sub-directory. My intuition for passing '.' was that it would just pack the project into the project name in the current directory. |
Your intuition was right and this function is currently not doing the right thing. It should work after this PR is merged. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Do we actually have updates on this PR? I think it would be helpful to have the functionality for Hackathon |
Not really, I most likely will not have time to finish this in the next days due to the NFDI meeting. But feel free to work on it if you find time. |
This itself has a fix now I believe #1047 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@srmnitc Do you plan to continue working on this? @jyang2009 is currently working on publishing her data for one project and we were wondering what the status of publishing the data is at the moment. |
|
I can pick this up again and finish it. Would be the week after Easter break. |
|
I merge this one to a normal branch ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of the
packandunpackmethods. #775packincludes the csv file inside the archivepackfilename is optional, uses ".tar.gz"packwith same name as project should not delete the projectpackselected jobs by idpackall files in a jobpackfrom a different directory than where project is locatedunpackmethod can be called aspr = Project(filename.tar.gz, unpack=True)orpr = Project(filename, unpack=True)unpackshould not nest project automaticallyunpackjobs into existing Project