Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add yml file #5

Merged
merged 23 commits into from
Oct 2, 2024
Merged

add yml file #5

merged 23 commits into from
Oct 2, 2024

Conversation

samwaseda
Copy link
Member

No description provided.

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/stinx/add_yml

Base automatically changed from remove_pyiron_base to main October 1, 2024 13:05
@samwaseda
Copy link
Member Author

@liamhuber this one is failing for reasons that I don’t really understand. Could you maybe take a look?

@liamhuber
Copy link
Member

I followed the link in the error message and see that Mambaforge is getting sunsetted. conda-incubator/setup-miniconda takes a miniforge variant argument. We default this to "Mambaforge", but you can change it:

https://github.com/pyiron/actions/blob/72012de602e4dbe8c1e5efa1b0bd32e63427fd02/cached-miniforge/action.yml#L28-L31

Try changing the miniforge-variant argument to see if that fixes it. Probably we need to change the default upstream in pyiron/actions/cached-miniforge too -- if this solution works, would you do that?

@samwaseda
Copy link
Member Author

How do I change it?

@liamhuber
Copy link
Member

Just as a keyword argument in the workflow. Look at workflows or another repo for an example

@liamhuber
Copy link
Member

  1. mea culpa -- I was wrong, the reusable actions don't let you drill down so deep in the action arguments as to expose pyiron/actions/cached-miniforge.miniforge-variant. The cached-miniforge action is nicely exposing the conda-incubator/setup-miniconda options, I just didn't propagate it all the way do the reusable workflows (which are usable only internally to the pyiron org), nor do I want to bother

  2. This just crashed all my daily tests too. I opened a PR to change the default target, but when I test it, I'm fighting with 404 errors for URLs that look like they ought to resolve to me...

@liamhuber
Copy link
Member

I'm fighting with 404 errors for URLs that look like they ought to resolve to me...

Ok, I just had a typo 🤦‍♂️

@samwaseda samwaseda merged commit 2f815e4 into main Oct 2, 2024
4 checks passed
@samwaseda samwaseda deleted the add_yml branch October 2, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants