[INF] Avoid timeouts in pre-commit ci/cd due to darglint #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatlittleboy
changed the title
|
🚀 Deployed on https://deploy-preview-1246--pyjanitor.netlify.app |
Codecov Report
@@ Coverage Diff @@
## dev #1246 +/- ##
===========================================
+ Coverage 86.75% 97.67% +10.92%
===========================================
Files 78 78
Lines 3617 3617
===========================================
+ Hits 3138 3533 +395
+ Misses 479 84 -395 |
samukweku
approved these changes
Feb 18, 2023
|
hello -- please merge this ASAP as it's significantly impacting queue at the moment |
|
@ericmjl I'll make the executive decision to merge this PR in first since it's affecting others; let's address further concerns in a separate PR, hope you don't mind! |
|
@asottile done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a tiny PR to turn off darglint in the pre-commit CI workflow for now --- as it's consistently taking >3min to run and timing out ---, and replacing it with GH actions.
It is currently hindering the other pre-commit checks (black) from being applied/auto-fixed in PRs as a result as well.
Locally, one would still use pre-commit to check darglint as per normal.
The plan is to use #1236 to replace darglint.
Also,
blackhas adopted a new style with the new 2023 release, so this PR also fixes that to conform our code to the new style.