Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Rust Api for Basic RunOptions Support #139

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

aykut-bozkurt
Copy link
Contributor

@aykut-bozkurt aykut-bozkurt commented Jan 12, 2024

The PR adds basic functionality to cancel active runs in a session via RunOptions Api.

Corresponding Rust methods are added for the following ONNX Runtime functions:

Corresponding Rust methods' signature changed to accept an additional Optional<Arc<RunOptions>> for the following ONNX Runtime functions:

Closes #136.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (0aec403) 35.72% compared to head (eafc147) 35.32%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/session/mod.rs 26.08% 17 Missing ⚠️
src/io_binding.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   35.72%   35.32%   -0.40%     
==========================================
  Files          31       31              
  Lines        1534     1554      +20     
==========================================
+ Hits          548      549       +1     
- Misses        986     1005      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@decahedron1 decahedron1 merged commit 45f96c1 into pykeio:main Jan 12, 2024
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancellation of Session Runs
2 participants