Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix config writing issue #16

Merged
merged 9 commits into from
Jun 8, 2021
Merged

fix config writing issue #16

merged 9 commits into from
Jun 8, 2021

Conversation

mihofer
Copy link
Contributor

@mihofer mihofer commented Jun 8, 2021

Fixes #15

instead of using __file__, the name of the script is now specified.
The former has led to some errors as the full path of the file was given and the config.ini was saved there then instead of the working_directory.

in save_config as the second leads to errors
@mihofer mihofer requested a review from JoschD June 8, 2021 15:25
@mihofer mihofer self-assigned this Jun 8, 2021
@mihofer mihofer added the Type: Bug Something isn't working as it should. label Jun 8, 2021
fsoubelet
fsoubelet previously approved these changes Jun 8, 2021
Copy link
Member

@fsoubelet fsoubelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks for the fix!

@fsoubelet
Copy link
Member

Maybe bump to 1.0.1 before merging as the fix deserves a patch release.

@codeclimate
Copy link

codeclimate bot commented Jun 8, 2021

Code Climate has analyzed commit 099e3e7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 92.5% (50% is the threshold).

This pull request will bring the total coverage in the repository to 64.0% (0.7% change).

View more on Code Climate.

@JoschD JoschD requested a review from fsoubelet June 8, 2021 18:04
@fsoubelet fsoubelet merged commit f2a3c38 into master Jun 8, 2021
@fsoubelet fsoubelet deleted the bug/15/config_file branch June 8, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix write config
3 participants