Improve recognition of _io module during bootstrapping on PyPy
#1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
added
Bug 🪳
needs-backport
pylint-tested
Pull Request Test Coverage Report for Build 2220687795
💛 - Coveralls |
Pierre-Sassoulas
approved these changes
Apr 25, 2022
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
May 2, 2022
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
This was added in 9d090ce.
However, with this change the test still passes. We have likely mitigated the circular dependency somewhere else. This line did make it so that we did not infer
builtinsdefined in_ioandio.Test show that we now infer this correctly 😄
I believe this is also the last remaining issue for pylint-dev/pylint#6406.
It will also make it possible to run some additional tests on
PyPyin `pylint.Type of Changes
Related Issue