Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argparse brain: avoid spurious addition of "namespace" to function locals #1608

Merged
merged 1 commit into from
Jun 9, 2022
Merged

argparse brain: avoid spurious addition of "namespace" to function locals #1608

merged 1 commit into from
Jun 9, 2022

Conversation

jacobtylerwalls
Copy link
Member

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Another manifestation of #1490.

Type of Changes

Type
✓ 🐛 Bug fix

Related Issue

Refs pylint-dev/pylint#6895

@jacobtylerwalls jacobtylerwalls added this to the 2.11.6 milestone Jun 9, 2022
@jacobtylerwalls jacobtylerwalls added Bug 🪳 Brain 🧠 Needs a brain tip labels Jun 9, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2465457218

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 92.219%
Totals Coverage Status
Change from base Build 2463920191: 0.09%
Covered Lines: 9339
Relevant Lines: 10127
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pylint's original issue was really surprising, good job on finding the fix !

@jacobtylerwalls jacobtylerwalls mentioned this pull request Jun 9, 2022
Merged
@jacobtylerwalls jacobtylerwalls merged commit f0bdc1b into pylint-dev:main Jun 9, 2022
@jacobtylerwalls jacobtylerwalls deleted the argparse-locals branch June 9, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord approved these changes

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Brain 🧠 Needs a brain tip Bug 🪳
Projects
None yet
Milestone
2.11.6
Development

Successfully merging this pull request may close these issues.
4 participants
@jacobtylerwalls @coveralls @Pierre-Sassoulas @DanielNoord