Don't rely on the module cache when "importing self"

ChangeLog

@@ -6,6 +6,9 @@ What's New in astroid 2.13.0?
 =============================
 Release date: TBA
 
+* Fixed importing self when a module had the same name as an installed package.
+
+  Refs PyCQA/pylint#7289
 
 
 What's New in astroid 2.12.3?

astroid/manager.py

@@ -147,9 +147,18 @@ def _can_load_extension(self, modname: str) -> bool:
             modname, self.extension_package_whitelist
         )
 
-    def ast_from_module_name(self, modname, context_file=None):
-        """given a module name, return the astroid object"""
-        if modname in self.astroid_cache:
+    def ast_from_module_name(
+        self,
+        modname: str | None,
+        context_file: str | None = None,
+        use_cache: bool = True,
+    ) -> nodes.Module:
+        """Given a module name, return the astroid object."""
+        # Sometimes we don't want to use the cache. For example, when we're
+        # importing a module with the same name as the file that is importing
+        # we want to fallback on the import system to make sure we get the correct
+        # module.
+        if modname in self.astroid_cache and use_cache:
             return self.astroid_cache[modname]
         if modname == "__main__":
             return self._build_stub_module(modname)

astroid/nodes/_base_nodes.py

@@ -128,25 +128,26 @@ def _infer_name(self, frame, name):
         return name
 
     def do_import_module(self, modname: str | None = None) -> nodes.Module:
-        """return the ast for a module whose name is <modname> imported by <self>"""
-        # handle special case where we are on a package node importing a module
-        # using the same name as the package, which may end in an infinite loop
-        # on relative imports
-        # XXX: no more needed ?
+        """Return the ast for a module whose name is <modname> imported by <self>."""
         mymodule = self.root()
-        level = getattr(self, "level", None)  # Import as no level
+        level: int | None = getattr(self, "level", None)  # Import has no level
         if modname is None:
             modname = self.modname
-        # XXX we should investigate deeper if we really want to check
-        # importing itself: modname and mymodule.name be relative or absolute
+        # If the module ImportNode is importing is a module with the same name
+        # as the file that contains the ImportNode we don't want to use the cache
+        # to make sure we use the import system to get the correct module.
         # pylint: disable-next=no-member # pylint doesn't recognize type of mymodule
         if mymodule.relative_to_absolute_name(modname, level) == mymodule.name:
-            # FIXME: we used to raise InferenceError here, but why ?
-            return mymodule
+            use_cache = False
+        else:
+            use_cache = True
 
         # pylint: disable-next=no-member # pylint doesn't recognize type of mymodule
         return mymodule.import_module(
-            modname, level=level, relative_only=level and level >= 1
+            modname,
+            level=level,
+            relative_only=bool(level and level >= 1),
+            use_cache=use_cache,
         )
 
     def real_name(self, asname):

astroid/nodes/scoped_nodes/scoped_nodes.py

@@ -498,27 +498,33 @@ def absolute_import_activated(self):
         """
         return self._absolute_import_activated
 
-    def import_module(self, modname, relative_only=False, level=None):
+    def import_module(
+        self,
+        modname: str | None,
+        relative_only: bool = False,
+        level: int | None = None,
+        use_cache: bool = True,
+    ) -> Module:
         """Get the ast for a given module as if imported from this module.
 
         :param modname: The name of the module to "import".
-        :type modname: str
 
         :param relative_only: Whether to only consider relative imports.
-        :type relative_only: bool
 
         :param level: The level of relative import.
-        :type level: int or None
+
+        :param use_cache: Whether to use the astroid_cache of modules.
 
         :returns: The imported module ast.
-        :rtype: NodeNG
         """
         if relative_only and level is None:
             level = 0
         absmodname = self.relative_to_absolute_name(modname, level)
 
         try:
-            return AstroidManager().ast_from_module_name(absmodname)
+            return AstroidManager().ast_from_module_name(
+                absmodname, use_cache=use_cache
+            )
         except AstroidBuildingError:
             # we only want to import a sub module or package of this module,
             # skip here

tests/resources.py

@@ -20,6 +20,10 @@ def find(name: str) -> str:
     return os.path.normpath(os.path.join(os.path.dirname(__file__), DATA_DIR, name))
 
 
+def find_in_testdata(name: str) -> Path:
+    return (Path(__file__).parent / "testdata" / name).resolve()
+
+
 def build_file(path: str, modname: str | None = None) -> Module:
     return builder.AstroidBuilder().file_build(find(path), modname)
 

tests/testdata/import_conflicting_names/math.py

@@ -0,0 +1,3 @@
+import math
+
+print(math)

tests/unittest_manager.py

@@ -325,6 +325,24 @@ def hook(modname: str):
             with self.assertRaises(AstroidBuildingError):
                 self.manager.ast_from_module_name("foo.bar.baz")
 
+    def test_same_name_import_module(self) -> None:
+        """test inference of an import statement with the same name as the module.
+
+        see https://github.com/pycqa/pylint/issues/7289.
+        """
+        data_dir = resources.find_in_testdata("import_conflicting_names")
+        math_file = data_dir / "math.py"
+        module = self.manager.ast_from_file(str(math_file))
+
+        # Change the cache key and module name to mimick importing the test file
+        # from the root/top level. This creates a clash between math.py and stdlib math.
+        self.manager.astroid_cache["math"] = self.manager.astroid_cache.pop(module.name)
+        module.name = "math"
+
+        # Infer the 'import math' statement
+        stdlib_math = next(module.body[1].value.args[0].infer())
+        assert self.manager.astroid_cache["math"] != stdlib_math
+
 
 class BorgAstroidManagerTC(unittest.TestCase):
     def test_borg(self) -> None: