Exclude unassigned type-annotated class attributes from enum __members__ container #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦, from the ``__members__`` container of an ``Enum`` class. Refs pylint-dev/pylint#7402
for more information, see https://pre-commit.ci
The value if now `Uninferable` in the case of an annotated attribute of an `enum.Enum` class with no assigned value.
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
These attributes cannot be none in real-world situations, see python/cpython#106145.
Updates the requirements on [sphinx](https://github.com/sphinx-doc/sphinx) to permit the latest version. - [Release notes](https://github.com/sphinx-doc/sphinx/releases) - [Changelog](https://github.com/sphinx-doc/sphinx/blob/master/CHANGES) - [Commits](sphinx-doc/sphinx@v7.0.0...v7.1.1) --- updated-dependencies: - dependency-name: sphinx dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2263 +/- ##
=======================================
Coverage 92.78% 92.78%
=======================================
Files 94 94
Lines 10951 10953 +2
=======================================
+ Hits 10161 10163 +2
Misses 790 790
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jacobtylerwalls
approved these changes
Aug 3, 2023
Pierre-Sassoulas
approved these changes
Aug 5, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/2.15.x maintenance/2.15.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/2.15.x
# Create a new branch
git switch --create backport-2263-to-maintenance/2.15.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 63cd8a1752f01391956f94cfde0c49de44f3726f
# Push it to GitHub
git push --set-upstream origin backport-2263-to-maintenance/2.15.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/2.15.xThen, create a pull request where the |
Pierre-Sassoulas
added
Needs backport
mbyrnepr2
deleted the
pylint_7402_exclude_unassigned_annassigns_from_enum_members
branch
jacobtylerwalls
removed
the
Needs backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Exclude type-annotated class attributes, which have no assigned value, from the
__members__container of anEnumclass.pylint-dev/pylint#7402