-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct pre-commit's pylint warnings #2407
Correct pre-commit's pylint warnings #2407
Conversation
The introduction of use-yield-from generated a new warning on the source code. Some messages no longer needed to be disabled as well. These warnings have been corrected to prevent pre-commit from failing.
Thank you @crazybolillo. I fixed that elsewhere (pytest cov bump). But there's still thé pypy 3.10 segfault. Might just merge despite the segfault. |
This comment was marked as outdated.
This comment was marked as outdated.
Nvm, upgrading stealthily like I did is bad practice. |
Seemed suspiciously easy. Now I am not so sure about my changes since it seems like the CI complains about the non-iterable while my local environment did not. Probably better to focus our efforts on your PR. I have not read much about the segfault you mention but I will see if I can be of any help. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2407 +/- ##
=======================================
Coverage 92.75% 92.76%
=======================================
Files 94 94
Lines 11088 11087 -1
=======================================
Hits 10285 10285
+ Misses 803 802 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Well the segfault is ever flaky or went in of order 😄 |
Thanks again @crazybolillo . Also yes, often the astroid's local need to be regenerated from scratch. Or we might have some skip to add on some tests. |
The introduction of use-yield-from generated a new warning on the source code. Some messages no longer needed to be disabled as well. These warnings have been corrected to prevent pre-commit from failing.
Type of Changes