Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct pre-commit's pylint warnings #2407

Merged

Conversation

crazybolillo
Copy link
Contributor

The introduction of use-yield-from generated a new warning on the source code. Some messages no longer needed to be disabled as well. These warnings have been corrected to prevent pre-commit from failing.

Type of Changes

Type
🔨 Refactoring

The introduction of use-yield-from generated a new warning on the source
code. Some messages no longer needed to be disabled as well. These
warnings have been corrected to prevent pre-commit from failing.
@Pierre-Sassoulas
Copy link
Member

Thank you @crazybolillo. I fixed that elsewhere (pytest cov bump). But there's still thé pypy 3.10 segfault. Might just merge despite the segfault.

@Pierre-Sassoulas

This comment was marked as outdated.

@Pierre-Sassoulas
Copy link
Member

Nvm, upgrading stealthily like I did is bad practice.

@crazybolillo
Copy link
Contributor Author

crazybolillo commented Apr 4, 2024

Seemed suspiciously easy. Now I am not so sure about my changes since it seems like the CI complains about the non-iterable while my local environment did not. Probably better to focus our efforts on your PR. I have not read much about the segfault you mention but I will see if I can be of any help.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (de942f3) to head (5d55b26).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2407   +/-   ##
=======================================
  Coverage   92.75%   92.76%           
=======================================
  Files          94       94           
  Lines       11088    11087    -1     
=======================================
  Hits        10285    10285           
+ Misses        803      802    -1     
Flag Coverage Δ
linux 92.57% <100.00%> (+<0.01%) ⬆️
pypy 90.77% <0.00%> (+<0.01%) ⬆️
windows 92.36% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
astroid/manager.py 89.53% <100.00%> (+0.37%) ⬆️

@Pierre-Sassoulas
Copy link
Member

Well the segfault is ever flaky or went in of order 😄

@Pierre-Sassoulas Pierre-Sassoulas merged commit 7a3b482 into pylint-dev:main Apr 4, 2024
20 checks passed
@Pierre-Sassoulas
Copy link
Member

Thanks again @crazybolillo . Also yes, often the astroid's local need to be regenerated from scratch. Or we might have some skip to add on some tests.

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants