Enhancement of numpy brain #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….numerictypes + add of corresponding unittest
PCManticore
approved these changes
Jan 30, 2018
|
Looks great @hippo91 ! Also don't forget to backport these patches to 1.6 branch, since we're going to do releases from there. |
|
Thanks @PCManticore! I'll backport it ASAP. |
hippo91
added a commit
to hippo91/astroid
that referenced
this pull request
Feb 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the problem of false positive
no-memberemission when usingnumpyand specific types (last part of #pylint-dev/pylint#779).The missing types have been added to the numpy brain and a corresponding unit test has been created.