Make use of cache while transform builtin containers #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislavlevin
force-pushed
the
builtin_container_recursion
branch
from
d2f6469 to
4a4c734
Compare
As of now, the transformation of builtin containers which members, in turn, are containers relies on `safe_infer` helper. `safe_infer` tries to infer the node to get its values. Doing this without a cache containing a previously inferred nodes lead to infinite recursion, for example, on resolving a class attribute. Note: this doesn't help to infer a class attribute by itself is such a case, but prevents crash. Closes: pylint-dev/pylint#3245 Signed-off-by: Stanislav Levin <slev@altlinux.org>
stanislavlevin
force-pushed
the
builtin_container_recursion
branch
from
4a4c734 to
01a0a7a
Compare
|
Thank you for the great PR @stanislavlevin ! |
|
This problem or a related problem still exists with pylint 2.14 and astroid 2.11 with qgis. It can be simply reproduced in a conda environment with qgis and installed and qgis added to the extension-pkg-allow-list in pylintrc, with a one line test.py file:
In on macOS Monterey, with Python 3.9. Crash report attached. |
|
This seems like another issue. Do you use any |
|
I don't know of any |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of now, the transformation of builtin containers which
members, in turn, are containers relies on
safe_inferhelper.
safe_infertries to infer the node to get itsvalues. Doing this without a cache containing a previously
inferred nodes lead to infinite recursion, for example, on
resolving a class attribute.
Type of Changes
Related Issue
Closes pylint-dev/pylint#3245