Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on maintenance/3.3.x #10009

Closed
jacobtylerwalls opened this issue Oct 7, 2024 · 4 comments
Closed

Tests fail on maintenance/3.3.x #10009

jacobtylerwalls opened this issue Oct 7, 2024 · 4 comments
Labels
Cannot reproduce 🤷 Stale This issue is stale and will be deleted automatically if nothing happens

Comments

@jacobtylerwalls
Copy link
Member

Somehow fixme-in-docstring leaked into the 3.3.x branch?

___________________ TestCallbackOptions.test_generate_rcfile ___________________

tmp_path = PosixPath('/tmp/pytest-of-runner/pytest-0/test_generate_rcfile0')

    @staticmethod
    def test_generate_rcfile(tmp_path: Path) -> None:
        """Test the --generate-rcfile flag."""
        args = _add_rcfile_default_pylintrc(["--generate-rcfile"])
        process = subprocess.run(
            [sys.executable, "-m", "pylint", *args],
            capture_output=True,
            encoding="utf-8",
            check=False,
            cwd=str(tmp_path),
        )
        assert "[MAIN]" in process.stdout
        assert "[MASTER]" not in process.stdout
        assert "profile" not in process.stdout
        args = _add_rcfile_default_pylintrc(["--generate-rcfile"])
        process_two = subprocess.run(
            [sys.executable, "-m", "pylint", *args],
            capture_output=True,
            encoding="utf-8",
            check=False,
            cwd=str(tmp_path),
        )
        assert process.stdout == process_two.stdout
    
        # Check that the generated file is valid
        with tempfile.NamedTemporaryFile(mode="w", delete=False) as temp:
            filename = temp.name
            temp.write(process.stdout)
            runner = Run(
                [join(HERE, "regrtest_data", "empty.py"), f"--rcfile={filename}"],
                exit=False,
            )
>           assert not runner.linter.msg_status
E           AssertionError: assert not 2
E            +  where 2 = Checker 'main' (responsible for 'F0001', 'F0002', 'F0010', 'F0011', 'I0001', 'I0010', 'I0011', 'I0013', 'I0020', 'I0021', 'I0022', 'E0001', 'E0011', 'W0012', 'R0022', 'E0013', 'E0014', 'E0015').msg_status
E            +    where Checker 'main' (responsible for 'F0001', 'F0002', 'F0010', 'F0011', 'I0001', 'I0010', 'I0011', 'I0013', 'I0020', 'I0021', 'I0022', 'E0001', 'E0011', 'W0012', 'R0022', 'E0013', 'E0014', 'E0015') = <pylint.testutils._run._Run object at 0x7f2abbe2d630>.linter

tests/test_self.py:[146](https://github.com/pylint-dev/pylint/actions/runs/11216506980/job/31175953299#step:7:147)4: AssertionError
----------------------------- Captured stdout call -----------------------------
************* Module /tmp/tmpp35y9uob
/tmp/tmpp35y9uob:1:0: E0015: Unrecognized option found: check-fixme-in-docstring (unrecognized-option)
@Pierre-Sassoulas Pierre-Sassoulas added the Blocker 🙅 Blocks the next release label Oct 7, 2024
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.3.2 milestone Oct 7, 2024
@Pierre-Sassoulas
Copy link
Member

Doesn't seem to fail in #10083 ?

@jacobtylerwalls jacobtylerwalls closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2024
@jacobtylerwalls jacobtylerwalls added Cannot reproduce 🤷 and removed Blocker 🙅 Blocks the next release labels Nov 19, 2024
@jacobtylerwalls jacobtylerwalls removed this from the 3.3.2 milestone Nov 19, 2024
@Pierre-Sassoulas
Copy link
Member

It seems that indeed fixme-in-docstring leaked into the 3.3.x branch (seeing the generated example in #10088 )

Copy link
Contributor

This issue is stale because it has been open 4 weeks with no activity. Remove 'Stale' label or comment or this will be closed in a week.

@github-actions github-actions bot added the Stale This issue is stale and will be deleted automatically if nothing happens label Dec 19, 2024
@Pierre-Sassoulas
Copy link
Member

Was fixed somehow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cannot reproduce 🤷 Stale This issue is stale and will be deleted automatically if nothing happens
Projects
None yet
Development

No branches or pull requests

2 participants