Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pylint to 3.3.2, update changelog #10088

Open
wants to merge 1 commit into
base: maintenance/3.3.x
Choose a base branch
from

Conversation

Pierre-Sassoulas
Copy link
Member

Other Bug Fixes

  • Fixes the issue with --source-root option not working when the source files are in a subdirectory of the source root (e.g. when using a /src layout).

    Closes Source root not correctly used #10026

@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Nov 20, 2024
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.3.2 milestone Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (5597aae) to head (2bfbf83).
Report is 1 commits behind head on maintenance/3.3.x.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           maintenance/3.3.x   #10088   +/-   ##
==================================================
  Coverage              95.80%   95.81%           
==================================================
  Files                    174      174           
  Lines                  18940    18951   +11     
==================================================
+ Hits                   18146    18157   +11     
  Misses                   794      794           
Files with missing lines Coverage Δ
pylint/__pkginfo__.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Comment on lines 459 to 461
# Whether or not to search for fixme's in docstrings.
check-fixme-in-docstring=no

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very suspicious : #10009

Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, then let's pump the brakes until we get fixme-in-docstring extracted. (Sorry if that was me!)

@Pierre-Sassoulas
Copy link
Member Author

I don't understand what's happening, but I start to be suspicious of the tbump script, as the code added to the misc checker clearly isn't present in the maintenance branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants