Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixme should trigger only on comments #2321

Closed
scop opened this issue Jul 18, 2018 · 5 comments
Closed

Fixme should trigger only on comments #2321

scop opened this issue Jul 18, 2018 · 5 comments
Labels

Comments

@scop
Copy link
Contributor

scop commented Jul 18, 2018

Steps to reproduce

  1. Run pylint on a file containing this line
print("# TODO this should not trigger a fixme")

Current behavior

todo_issues.py:1:0: W0511: TODO this should not trigger a fixme") (fixme)

Expected behavior

(no messages)

So pylint should be looking only into what are actual comments, not into everything that follows a #.

pylint --version output

pylint 2.0.0
astroid 2.0.0.dev4
Python 3.7.0 (default, Jun 29 2018, 21:39:54)
[GCC 7.2.0]

@PCManticore
Copy link
Contributor

Thanks, this makes sense!

@PCManticore
Copy link
Contributor

@sushobhit27 I'm pretty sure this still reproduces in the latest version :)

@sushobhit27
Copy link
Contributor

@PCManticore ok, I labelled few other issues also after finding them working fine with 2.1.0, can you check those issues also?

@scop
Copy link
Contributor Author

scop commented Aug 9, 2018

(FWIW I would find an explicit "fixed in x.y.z" label more useful than "fixed in latest version". The latter is pretty much the same as no label at all plus leaving bugs open until a release that contains the fix is out.)

@PCManticore
Copy link
Contributor

Agreed, latest might mean different things for different people (1.9.X for folks using Python 2)

rogalski pushed a commit that referenced this issue Aug 24, 2018
PCManticore added a commit that referenced this issue Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants