Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Enum with self defined members #5138

Closed
OldIMP opened this issue Oct 10, 2021 · 1 comment · Fixed by #5847
Closed

Support Enum with self defined members #5138

OldIMP opened this issue Oct 10, 2021 · 1 comment · Fixed by #5847
Labels
Enhancement ✨ Improvement to a component False Positive 🦟 A message is emitted but nothing is wrong with the code
Milestone
2.14.0

Comments

@OldIMP
Copy link

OldIMP commented Oct 10, 2021 •
edited
Loading

Current problem

False positive E1101 are reported for self defined member in Enums.

Example:

  • Enum Layout w/ self defined members col & row
  • Here will then be reported falsely as E1101:

    r_quiz.py:174:12: E1101: Instance of 'SIMPLE' has no 'row' member (no-member)
    r_quiz.py:174:12: E1101: Instance of 'SCHRIFTLICH' has no 'row' member (no-member)
    r_quiz.py:174:25: E1101: Instance of 'SIMPLE' has no 'col' member (no-member)
    r_quiz.py:174:25: E1101: Instance of 'SCHRIFTLICH' has no 'col' member (no-member)

pylint --version

pylint 2.11.1
astroid 2.8.2
Python 3.9.7 | packaged by conda-forge | (default, Sep 29 2021, 19:15:42) [MSC v.1916 64 bit (AMD64)]

Desired solution

According to Python doc, self defined members in Enums are allowed. Therefore no issues should be reported for the example above.

Additional context

No response
@OldIMP OldIMP added Enhancement ✨ Improvement to a component Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling labels Oct 10, 2021
@OldIMP OldIMP mentioned this issue Oct 10, 2021
Closed
@Pierre-Sassoulas Pierre-Sassoulas added False Positive 🦟 A message is emitted but nothing is wrong with the code and removed Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling labels Oct 11, 2021
@marianhlavac
Copy link

Any progress on this?

huwcbjones added a commit to huwcbjones/pylint that referenced this issue Feb 27, 2022
@huwcbjones
Initial pass at fixing pylint-dev#5138
d090238 
Add _enum_has_attribute to typechecker to parse AST and find attribute assignments
in __new__.
@huwcbjones huwcbjones mentioned this issue Feb 27, 2022
Merged
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.14.0 milestone Feb 27, 2022
huwcbjones added a commit to huwcbjones/pylint that referenced this issue Mar 6, 2022
@huwcbjones
Initial pass at fixing pylint-dev#5138
22a1e4f 
Add _enum_has_attribute to typechecker to parse AST and find attribute assignments
in __new__.
huwcbjones added a commit to huwcbjones/pylint that referenced this issue May 1, 2022
@huwcbjones
Initial pass at fixing pylint-dev#5138
e668e9f 
Add _enum_has_attribute to typechecker to parse AST and find attribute assignments
in __new__.
huwcbjones added a commit to huwcbjones/pylint that referenced this issue May 4, 2022
@huwcbjones
Initial pass at fixing pylint-dev#5138
5febb6c 
Add _enum_has_attribute to typechecker to parse AST and find attribute assignments
in __new__.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement ✨ Improvement to a component False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.14.0
Development

Successfully merging a pull request may close this issue.

Enum: Add support for self-defined members huwcbjones/pylint
3 participants
@marianhlavac @Pierre-Sassoulas @OldIMP