Fix indentation handling with tabs (Issue: #1148) #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x539
changed the title
added 3 commits
March 17, 2018 23:54
A Tab is not equal to 8 spaces. So just counting tabs as 8 spaces is wrong. Use the whole 'tabs' and/or 'spaces' string for indentation checks instead of some imaginary number of whitespaces.
x539
changed the title
|
I'm going try to get this merged.. Might take me awhile since I'm not familiar with this section of pylint |
brycepg
reviewed
Mar 21, 2018
| @@ -0,0 +1,3 @@ | |||
| [FORMAT] | |||
| indent-string='\t' | |||
| indent-after-paren=1 | |||
There was a problem hiding this comment.
@Could you add a newline at the end of the file?: https://stackoverflow.com/questions/5813311/no-newline-at-end-of-file
brycepg
reviewed
Mar 21, 2018
pylint/checkers/format.py
Outdated
| """Return the indention string of the given line.""" | ||
| result = '' | ||
| for char in line: | ||
| if char == ' ' or char == '\t': |
There was a problem hiding this comment.
This if statement could be written as if char in '\t ': (no need to change if you don't want to though)
brycepg
reviewed
Mar 21, 2018
|
|
||
| def d(self, e): | ||
| self.b( | ||
| e) # [bad-continuation] |
There was a problem hiding this comment.
Why does line 24 raise bad-continuation but not 20?
There was a problem hiding this comment.
Oh looks like this line has mixed tabs and spaces
brycepg
reviewed
Mar 21, 2018
pylint/checkers/format.py
Outdated
| def line_indent(self, idx): | ||
| return _get_indent_string(self.line(idx)) | ||
|
|
||
| def token_indent(self, idx): |
There was a problem hiding this comment.
Could you add docstrings here explaining these methods?
brycepg
approved these changes
Mar 21, 2018
|
Nice work @x539 ! I'm glad to have this fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Tab is not equal to 8 spaces. So just counting tabs as 8 spaces is wrong.
Use the whole 'tabs' and/or 'spaces' string for indentation checks
instead of some imaginary number of whitespaces.
Fixes