Add regression tests for astroid 2.7.0 fixes #4816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
False Positive 🦟
Pierre-Sassoulas
changed the title
Pierre-Sassoulas
force-pushed
the
regression-test-533-2224-2626
branch
from
7e743ef to
7e8710d
Compare
Pierre-Sassoulas
force-pushed
the
regression-test-533-2224-2626
branch
from
7e8710d to
dffdc1f
Compare
| @@ -1,4 +1,6 @@ | |||
| # pylint: disable=missing-docstring, too-few-public-methods, useless-object-inheritance | |||
| from dataclasses import dataclass, InitVar | |||
There was a problem hiding this comment.
@Pierre-Sassoulas this was an oversight on my part---dataclasses was introduced in Python 3.7, which is why the tests are failing on 3.6. I think the right fix is to move this test into a separate file do do the min_pyver configuration?
There was a problem hiding this comment.
Yes there are other example in the functional test. (same name with _py37 would work). You made the code we'll need in 4 months :) We need to support python 3.6 until its end of life, but it's close now.
2 tasks
Pull Request Test Coverage Report for Build 1136246062
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Tests for pylint-dev/astroid#1121 and pylint-dev/astroid#1126