-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typecheck tests for dataclass attributes #4870
Add typecheck tests for dataclass attributes #4870
Conversation
26f4d2d
to
97e467d
Compare
Update: I had to update the test astroid version to 2.7.1 (to include the patch in pylint-dev/astroid#1130). Is this okay? Should I have updated |
It's okay to increase the astroid version, actually I forgot to do it after releasing 2.7.1 so thank you. But yes both versions should be in sync, or the test can run properly but the installation fail if the wrong version of astroid is used. |
2c93bed
to
57f64ab
Compare
57f64ab
to
f1cba50
Compare
Pull Request Test Coverage Report for Build 1148685588
π - Coveralls |
Thank you for that and the prior refactor ! |
Type of Changes
Description
Added additional tests for some basic type-checking of attributes from dataclasses, motivated by the changes in pylint-dev/astroid#1126.
Comments
I didn't add an entry to the Changelog, but I can if you want.
I identified a few false negatives as well in some of the typecheck checks, but I didn't submit any code changes here.
Also, wow the
invalid-metaclass
error output is... not great?