-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PyreverseConfig imports in pyreverse's tests #5010
Fix PyreverseConfig imports in pyreverse's tests #5010
Conversation
@DudeNr33 fyi, I just realized that pytest is adding all file to the pythonpath so the tests were working but not pylint or mypy :) |
Pull Request Test Coverage Report for Build 1236529571
π - Coveralls |
How about we move this class to pylint.pyreverse? It seems it's an interface for optparse.Config that might help with typing for pylint's code too. |
No, not really - the "real" config class comes from the |
This is actually preventing me from running the test suite locally. I get: ../../../../.pyenv/versions/3.9.6/lib/python3.9/importlib/__init__.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
tests/pyreverse/test_writer.py:31: in <module>
from tests.pyreverse.conftest import PyreverseConfig
E ModuleNotFoundError: No module named 'tests' with |
Type of Changes
Description
Fix an import error due to pytest adding all file to the pythonpath before launching tests.