Update primer tests to own file, separate batches and concurrent runs
#5425
Conversation
DanielNoord
added
Maintenance
Pull Request Test Coverage Report for Build 1513660652
💛 - Coveralls |
|
Times between both batches seem fairly equal so I think this division works. Run time is quite high as US is starting to launch GitHub Actions at this time.. Looks good for review! |
There was a problem hiding this comment.
I just had a quick look but it look amazing already !I'll do a full review tomorrow. 27mn to 16mn is perfect, it's almost the timing of our test suite before primers !
I was reading the doc for github caching so we download the repositories only once. I think if we choose a particular commit we can even cache reliably between runs as long as we do not update to the latest commits. I'll do that in another MR though, everything here was required, is compatible and will also make things faster anyway !
| pip install -e . | ||
| pytest -m primer_external_batch_one --primer-external -n auto | ||
|
|
||
| pytest-primer-external-batch-two: |
There was a problem hiding this comment.
I was trying to find a way to not copy paste so much, did you also search and find nothing acceptable or did you simply implement something fast ?
There was a problem hiding this comment.
I simply implemented something fast. Do you want me to look if something is possible before merging?
There was a problem hiding this comment.
No, let's keep the MR small and do it later on. Also this CI speed up is too valuable to wait, clearly 😄
Type of Changes
Description
First set of improvements for the
primer. This adds:primernow only runs on changes topylint/**ortests/primer/**or pushes tomain. This should allow updating docs or tests without the primer holding you up.primersits in its own workflow fileprimerhas been bursted into two batches based on the first half of the alphabet and the second 😄Ref #5359