Regression tests for 73 (distutil import error) #5620
Conversation
Pierre-Sassoulas
added
Astroid
Pull Request Test Coverage Report for Build 1640977431
💛 - Coveralls |
| from distutils.util import strtobool | ||
|
|
||
| print(distutils.version) | ||
| print(strtobool) |
There was a problem hiding this comment.
DIdn't we also want to have a test to see that distutils still emitted no-member for incorrect imports? We might want to add one case here.
| """ | ||
| Regression test to check that distutils can be imported |
There was a problem hiding this comment.
| """ | |
| Regression test to check that distutils can be imported | |
| """Regression test to check that distutils can be imported |
We need to find some pre-commit hook that starts to enforce this.
Perhaps we can look at something for Path at the same time? 😄
There was a problem hiding this comment.
There was a problem hiding this comment.
Better yet https://github.com/myint/docformatter
There was a problem hiding this comment.
For module docstrings I think both are fine. Those are tests after all.
Perhaps we can look at something for Path at the same time? 😄
I wouldn't recommend that. It's not really worth it and might limit us more than it actually would help.
There was a problem hiding this comment.
I wouldn't recommend that. It's not really worth it and might limit us more than it actually would help.
This was a little joke as @Pierre-Sassoulas keeps having to remind me to use it on the PRs I open 😄
Don't think we should enforce it all the time indeed.
Perhaps those packages allow us to exclude modules? Oh well, something to explore another time.
There was a problem hiding this comment.
Yes we definitely don't want to refactor all the old code that uses os.path.
I renamed :) Although I think having a nice explicit name is better than "regression_1234" so I kept the explicit part. |
| @@ -57,7 +57,7 @@ class MessageLocationTuple(NamedTuple): | |||
|
|
|||
|
|
|||
| class ManagedMessage(NamedTuple): | |||
| """Tuple with information ahout a managed message of the linter""" | |||
| """Tuple with information about a managed message of the linter""" | |||
There was a problem hiding this comment.
Perhaps clean up the commit history and don't squash?
There was a problem hiding this comment.
You're right I wanted to rebase originally but there are other commits that prevents that now.
Following change in the way distutil is stored in setuptools See pylint-dev/astroid#1321
Pierre-Sassoulas
force-pushed
the
regression-tests-for-73
branch
from
22524d2 to
9a6afd3
Compare
Type of Changes
Description
Refer to pylint-dev/astroid#1321