-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also test on PyPy 3.7 #5853
Also test on PyPy 3.7 #5853
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with fixing the issue with the line/col either in 2.13 or 2.14 :)
.github/workflows/ci.yaml
Outdated
@@ -476,7 +476,7 @@ jobs: | |||
with: | |||
path: venv | |||
key: | |||
${{ runner.os }}-${{ steps.python.outputs.python-version }}-${{ | |||
${{ runner.os }}-${{ matrix.python-version }}-${{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be necessary. The Set up Python
version will output ${{ matrix.python-version }}
. As far as I can tell, the tests didn't crash.
https://github.com/PyCQA/pylint/runs/5376859270?check_suite_focus=true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this doesn't work as well.
Please see the version of pytest
in the pypy-3.7
run. That's the 3.6
version. You can see they are using the same cache in the Restore Python virtual environment
job. The key
is the same.
However, my fix also doesn't work. I guess something weird is going on with python-version
and PyPy
? For the cpython
jobs the keys do work..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pretty much looks like a bug in the setup-python
actions. If I had to guess a result of actions/setup-python#342.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened actions/setup-python#345.
I'll draft this until I get a response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an issue with the current caching on I could do a separate PR for the fix, but I think it should be fine to squash here, or to add two commits and rebase here. For the future: we should remove |
Pull Request Test Coverage Report for Build 1916864181
π - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rebased the PR to only include the addition of pypy-3.7
.
Don't know if you wanted to do anything else, so will leave it as draft for now. Feel free to merge it though if it's finished.
Thanks @cdce8p, I'm going to merge this! |
Type of Changes
Description
See #5849 (comment).