Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python-typing-update on pylint directory #6302

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

DanielNoord
Copy link
Collaborator

@DanielNoord DanielNoord commented Apr 14, 2022

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

Ref #4683.

@DanielNoord DanielNoord added typing Maintenance Discussion or action around maintaining pylint or the dev workflow labels Apr 14, 2022
@DanielNoord DanielNoord added this to the 2.14.0 milestone Apr 14, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2165882374

  • 27 of 27 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 93.378%

Totals Coverage Status
Change from base Build 2163787619: 0.002%
Covered Lines: 15877
Relevant Lines: 17003

πŸ’› - Coveralls

@DanielNoord
Copy link
Collaborator Author

@cdce8p Thanks for the review.

Not sure if this is something you want to look into but I noticed the tool has some trouble with our copyright notices and module docstrings. Removing most whitespaces around them. Might also be because of reorder-imports, but it could be something you want to look into.

@DanielNoord DanielNoord merged commit 2b2d1b5 into pylint-dev:main Apr 14, 2022
@DanielNoord DanielNoord deleted the 3.7 branch April 14, 2022 08:00
@cdce8p
Copy link
Member

cdce8p commented Apr 14, 2022

Not sure if this is something you want to look into but I noticed the tool has some trouble with our copyright notices and module docstrings. Removing most whitespaces around them. Might also be because of reorder-imports, but it could be something you want to look into.

Saw that too. I think it's not that big of an issue. As you said, likely caused by reorder-imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants