Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python-typing-update on pylint/testutils directory #6303

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

Ref #4683.

@DanielNoord DanielNoord added typing Maintenance Discussion or action around maintaining pylint or the dev workflow labels Apr 14, 2022
@DanielNoord DanielNoord added this to the 2.14.0 milestone Apr 14, 2022
@DanielNoord
Copy link
Collaborator Author

@cdce8p Want me to keep doing this in batches or do you trust the tool enough to do one big PR?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2165953069

  • 70 of 70 (100.0%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 93.38%

Totals Coverage Status
Change from base Build 2165949081: 0.003%
Covered Lines: 15884
Relevant Lines: 17010

πŸ’› - Coveralls

@cdce8p
Copy link
Member

cdce8p commented Apr 14, 2022

@cdce8p Want me to keep doing this in batches or do you trust the tool enough to do one big PR?

If it's not too much effort, I would recommend batches. Although I do trust my tool, smaller chunks are much easier too review.

@DanielNoord
Copy link
Collaborator Author

If it's not too much effort, I would recommend batches. Although I do trust my tool, smaller chunks are much easier too review.

Batches is easy enough! Just wanting the way that's easiest for all πŸ˜„

@DanielNoord DanielNoord merged commit c4fa0a7 into pylint-dev:main Apr 14, 2022
@DanielNoord DanielNoord deleted the 3.7 branch April 14, 2022 08:13
@cdce8p
Copy link
Member

cdce8p commented Apr 14, 2022

You can tag me for reviews if you want. Just to make sure I see the PRs πŸ˜ƒ

@DanielNoord
Copy link
Collaborator Author

πŸ‘

I was hesitant as I know you're often busy and there is still quite some PRs to go. Didn't want to be too pushy. But I'll tag you πŸ˜„

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants