Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python-typing-update on pylint/config directory #6307

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

Ref #4683.

@DanielNoord DanielNoord requested a review from cdce8p April 14, 2022 08:43
@DanielNoord DanielNoord added this to the 2.14.0 milestone Apr 14, 2022
@DanielNoord DanielNoord added Maintenance Discussion or action around maintaining pylint or the dev workflow typing labels Apr 14, 2022
_ExtendArgument,
]:
opt: str, optdict: dict[str, Any]
) -> _StoreArgument | _StoreTrueArgument | _CallableArgument | _StoreOldNamesArgument | _StoreNewNamesArgument | _ExtendArgument:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdce8p For some reason black doesn't format this. Is this a known issue? And if so, how do we want to format this ourselves?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. You could try adding brackets and see if that helps with black.

    ...
) -> (
    _StoreArgument
    | _StoreTrueArgument
    ...
)

@DanielNoord DanielNoord merged commit 99ef057 into pylint-dev:main Apr 14, 2022
@DanielNoord DanielNoord deleted the 3.7 branch April 14, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants