Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use python-typing-update on pylint/extensions directory #6308

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Use python-typing-update on pylint/extensions directory #6308

merged 2 commits into from
Apr 14, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🔨 Refactoring

Description

Ref #4683.

@DanielNoord DanielNoord requested a review from cdce8p April 14, 2022 08:51
@DanielNoord DanielNoord added this to the 2.14.0 milestone Apr 14, 2022
@DanielNoord DanielNoord added typing Maintenance Discussion or action around maintaining pylint or the dev workflow labels Apr 14, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2166210136

  • 75 of 75 (100.0%) changed or added relevant lines in 22 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 93.277%
Totals Coverage Status
Change from base Build 2166186558: 0.008%
Covered Lines: 15941
Relevant Lines: 17090
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing cleanup up with all those MR using python-typing-update 👍

@DanielNoord DanielNoord merged commit 47e168c into pylint-dev:main Apr 14, 2022
@DanielNoord DanielNoord deleted the 3.7 branch April 14, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@cdce8p cdce8p Awaiting requested review from cdce8p cdce8p is a code owner

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow typing
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas