Use python-typing-update on pylint/pyreverse directory
#6309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
added
typing
Maintenance
| Tuple[str, str, str, str, int, int], | ||
| MessageLocationTuple, | ||
| ], | ||
| location: (tuple[str, str, str, str, int, int] | MessageLocationTuple), |
There was a problem hiding this comment.
Suggested change
| location: (tuple[str, str, str, str, int, int] | MessageLocationTuple), | |
| location: MessageLocationTuple, |
Could we do this ? It seems those should be the same thing.
There was a problem hiding this comment.
No, see the deprecation warning a couple of lines below. location needs to be initialised as MessageLocationTuple and not be a regular tuple.
| ... | ||
|
|
||
| @overload | ||
| def __new__( | ||
| cls, | ||
| msg_id: str, | ||
| symbol: str, | ||
| location: Tuple[str, str, str, str, int, int], | ||
| location: tuple[str, str, str, str, int, int], |
There was a problem hiding this comment.
Suggested change
| location: tuple[str, str, str, str, int, int], | |
| location: MessageLocationTuple, |
(🤞 ?)
Pull Request Test Coverage Report for Build 2166275252
💛 - Coveralls |
Pierre-Sassoulas
approved these changes
Apr 14, 2022
cdce8p
reviewed
Apr 14, 2022
| Tuple[str, str, str, str, int, int], | ||
| MessageLocationTuple, | ||
| ], | ||
| location: (tuple[str, str, str, str, int, int] | MessageLocationTuple), |
There was a problem hiding this comment.
The brackets could have been removed here though.
- location: (tuple[str, str, str, str, int, int] | MessageLocationTuple),
+ location: tuple[str, str, str, str, int, int] | MessageLocationTuple,There was a problem hiding this comment.
Added in follow-up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Ref #4683.
@Pierre-Sassoulas @cdce8p Perhaps comment if you're going to review as not to duplicate work.