Use python-typing-update on half of the tests directory

[DanielNoord]

• Add yourself to CONTRIBUTORS if you are a new contributor.
• Write a good description on what the PR does.

Type of Changes

	Type
✓	🔨 Refactoring

Description

Ref #4683.

[coveralls]

Pull Request Test Coverage Report for Build 2168507121

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 93.373%

---

Totals
Change from base Build 2168404955:	0.0%
Covered Lines:	15964
Relevant Lines:	17097

---

💛 - Coveralls

[Pierre-Sassoulas]

Not that it's a problem, but there's unrelated change there ?

[DanielNoord]

Yeah I noticed it too. It's probably from an of the upgrade tools in Marc's tool updating this as well due to the 3.9+ flag.
However, I think it is actually a good change 😄

[Pierre-Sassoulas]

Hmm that's suspicious though, in python 3.8 __file__ is not abspathed:

cat a.py    
print(__file__)
python3 a.py
a.py

cat a.py 
import os

print(os.path.abspath(__file__))
python3 a.py
/home/pierre/astroid/a.py

[DanielNoord]

Hmm is it related to dirname perhaps?

[Pierre-Sassoulas]

Ho, it's actually worst if we take dirname into account:

cat a.py    
import os

print(os.path.dirname(__file__))
python3 a.py
 #nothing printed

cat a.py    
import os

print(os.path.dirname(os.path.abspath(__file__)))
python3 a.py
/home/pierre/astroid

(This is python 3.8)

[DanielNoord]

Do we want to revert?

[Pierre-Sassoulas]

I think it's safer.

[cdce8p]

I think it's safer.

I agree. Let's revert it here.

[cdce8p]

Let's just focus on the typing changes here.
As part of python-typing-update, pyupgrade is run. The version setting is passed directly to it. If those updates depend on --py39-plus we probably shouldn't do them at this time.

[cdce8p]

I think it's safer.

I agree. Let's revert it here.